search

futo-org / grayjay-android

Read-only mirror of Grayjay repo for issue tracking
https://gitlab.futo.org/videostreaming/grayjay
Other
750 stars 48 forks source link

Plugin login session expired without notification #809

Open Blotz opened 8 months ago

Blotz commented 8 months ago

The YouTube plugin worked fine till a week ago, when the account session expired without notification. There was no notification or error saying that the account logged out, and I had to re-enter my password for it to continue to work. I only found out when I tried commenting on a live stream and saw the account was logged out.

Having a notification or prompt which tells the user if your account is logged out would help avoid this issue in the future.

Blotz commented 8 months ago

It also logged me out of twitch, so I believe its platform independent.

koen-futo commented 8 months ago

This is definitely something we are working on still. These things are quite hard for us to reproduce. We have remained logged-in without issues on accounts for months without reproducing this issue.

If there is anything you are doing like changing password, or anything that you can think of might have caused you to logout. Please share.

Blotz commented 8 months ago

Oh, sure I can offer more information.

I use GrayJay with the "Provide YouTube Activity" disabled. I didn't change my password since logging in. (pretty confident because i use a password manager) I rarely log into Twitch or YouTube on other devices. I have been using the same GrayJay client/session since that time, when a build was pushed with missing dependencies (Dec 9, 2023). If I had to estimate, I would say it worked for 2 months before deauthenticating me. I was using the YT client for a while before I realised I wasn't signed in. I might have changed a security for Google, but that wouldn't explain why Twitch also logged out. I never touch anything to do with Twitch.

Not sure if any of this is relevant, but I hope it gives a clearer picture of the issue.

I only have passing knowledge of OAuth so feel free to ignore me. How does the GrayJay client refresh the log in tokens? This feels like a situation where the session expired before GrayJay had a chance to refresh.

Blotz commented 8 months ago

This issue happened to another user too #840

Also possibly #823 while I'm looking through issues

Blotz commented 6 months ago

So this issue has happened twice again since