search

futpib / policeman

Firefox extention for cross-site requests control (kind of RequestPolicy clone)
https://addons.mozilla.org/en-US/firefox/addon/policeman/
142 stars 11 forks source link

Ruleset preferences page has the "Save" button that is easy to miss #149

Closed Halibut80 closed 9 years ago

Halibut80 commented 9 years ago

After enabling "HTTPS sandbox" ruleset, image from hosting in the persistent whitelist (and does not supporting https) does not blocked after page refresh (I set "HTTPS sandbox" higher priority position in list of rulesets, than persistent rules), only after browser restart. Same after disabling "HTTPS sandbox" ruleset.

Policeman 0.18pre6

bastik-1001 commented 9 years ago

I am unable to reproduce this with 0.18pre9.

@Halibut80 Did you click on "Save" at the bottom of the ruleset list after rearranging or enabling/disabling rulesets?

Halibut80 commented 9 years ago

Oh, sorry.., I forgot about "save".

bastik-1001 commented 9 years ago

@futpib Can you think of some indicator to notify the user that he might want to save changes he made to the ruleset list? Something non-intrusive that helps to prevent errors like this one. Would be bad if people believe Policeman is broken.

futpib commented 9 years ago

@bastik-tor It saves automatically when tab is closed (or another prefs subpage opened)

futpib commented 9 years ago

Oh, I got it. Maybe it should just apply new setting immediately on change leaving only "Undo" button. Anyway, I don't think it's a big deal.

And, for that matter, it should look and behave like the addons list on about:addons (and like greasemonkey scripts, stylish styles etc.)

Halibut80 commented 9 years ago

@futpib New firefox preferences "in-content" apply settings after changes, this is why i forgot about need to click on save button. Apply new setting immediately on change - good deal, I agree.

Halibut80 commented 9 years ago

Also, this is need to unification interface with Nightly https://github.com/futpib/policeman/issues/123