Some requests have wrong content type

futpib / policeman

Firefox extention for cross-site requests control (kind of RequestPolicy clone)

https://addons.mozilla.org/en-US/firefox/addon/policeman/

142 stars 11 forks source link

Some requests have wrong content type #173

Open futpib opened 9 years ago

futpib commented 9 years ago

Reported here.

Buggy page link.

benoit-pierre commented 9 years ago

This bug makes Policeman-0.19pre1 completely unusable for me as it happens a lot. So I did a regression test with git bisect; and I can confirm that Policeman-0.18.1 works fine, apparently the bug was introduced by this commit.

Note:

I first ran into issues when rebuilding from source, because the version available in Arch Linux for jison is too old (AUR, 0.3.12), maybe those dependencies should be mentioned in the README?
when rebuilding 0.19pre1 from source, I noticed the official release has an extra lib/ruleset/content-types.js, normal?

futpib commented 9 years ago

@benoit-pierre Thanks, that's very helpful. I'll get to this issue as soon as I can.

Dependencies should be mentioned in README or on wiki somewhere under "Contributing" header, they are currently mentioned in build.sh --help without versions, since I don't keep track of tools versions and try to use the latest available.
It's whatever was untracked in my tree when I built it, that code is likely to be unreachable anyway.

braveheartleo commented 9 years ago

I just wish to chime in and say that this issue does not make policeman-0.19pre1 completely unusable, especially if one reloads the affected page to let Policeman properly re-match the resources to the existing user rules from that point forward, but it does happen a lot and makes browsing a little bit more inconvenient.