futpib / policeman

Firefox extention for cross-site requests control (kind of RequestPolicy clone)
https://addons.mozilla.org/en-US/firefox/addon/policeman/
143 stars 11 forks source link

jpg "Images" detected as "Other" #202

Closed Firminator closed 9 years ago

Firminator commented 9 years ago

http://computerbase.de to reproduce. imagesother

Tanath commented 9 years ago

Also those with .jpeg extension, and PNG as well.

Halibut80 commented 9 years ago

https://github.com/futpib/policeman/issues/173

chrisbura commented 9 years ago

It looks like this is being caused by a new content type in nsIContentPolicy. When an image is loaded via <img srcset="..."> it is classified as

/**
 * Indicates a <img srcset> or <picture> request.
 */
const nsContentPolicyType TYPE_IMAGESET = 21;

See here

http://mxr.mozilla.org/mozilla-central/source/dom/base/nsIContentPolicyBase.idl#170

Since it isn't an available content type here it gets classified as Other here.

The MDN docs haven't been updated to reflect the new content type. I ran into this problem when updating Firefox from 36 to 38 while maintaining the same Policeman version 0.18.1.1