search

futres / template

user template for FuTRES data import
0 stars 0 forks source link

measurementValue #73

Closed meghalithic closed 4 years ago

meghalithic commented 4 years ago

measurementValues were being passed like "NOT MEASURED" and "frag." which probably shouldn't have been passed. The DEF for measurementValue should probably be changed to float instead of string to catch these unwanted values.

jdeck88 commented 4 years ago

fixed.

jdeck88 commented 4 years ago

The DEF indicates FLOAT under data type. i changed the definition to say " The numerical value of the measurement...."

On Mon, Jul 27, 2020 at 10:22 AM Meghan Balk notifications@github.com wrote:

measurementValues were being passed like "NOT MEASURED" and "frag." which probably shouldn't have been passed. The DEF for measurementValue should probably be changed to float instead of string to catch these unwanted values.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/futres/template/issues/73, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZ3RM6XUB2UVX4QBDNPADR5WZWJANCNFSM4PJAVBLQ .

-- John Deck (541) 914-4739

meghalithic commented 4 years ago

Thanks!

On Mon, Jul 27, 2020 at 2:40 PM John Deck notifications@github.com wrote:

The DEF indicates FLOAT under data type. i changed the definition to say " The numerical value of the measurement...."

On Mon, Jul 27, 2020 at 10:22 AM Meghan Balk notifications@github.com wrote:

measurementValues were being passed like "NOT MEASURED" and "frag." which probably shouldn't have been passed. The DEF for measurementValue should probably be changed to float instead of string to catch these unwanted values.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/futres/template/issues/73, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAIZ3RM6XUB2UVX4QBDNPADR5WZWJANCNFSM4PJAVBLQ

.

-- John Deck (541) 914-4739

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/futres/template/issues/73#issuecomment-664652754, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSPR5HNG556EZU2L24EHZLR5XX6RANCNFSM4PJAVBLQ .

--

Meghan A. Balk, Ph.D. https://sites.google.com/view/megbalk/home Postdoctoral Research Associate, FuTRES https://futres.org/ Bio5 Institute, University of Arizona