search

futtta / ao_critcss_aas

Autoptimize power-up to integrate with criticalcss.com
9 stars 1 forks source link

Add possibility to use different / own critical CSS service #113

Closed dipiana closed 5 years ago

dipiana commented 5 years ago

I absolutely love your plugin(s), such amazing work. Just came across the critical CSS plugin which I found very interesting. Unfortunately, the monthly pricing adds up when you want to use it on many pages.

What do you think about adding the option to use a different / open source service to extract critical CSS?

There are some promising libraries on GitHub more advanced users could setup on their own servers and then use with your plugin.

For example: https://github.com/pocketjoso/penthouse https://github.com/stereobooster/react-snap https://github.com/addyosmani/critical

I think it would be an enormous benefit for many people (including me).

Highly appreciate your work.

Thanks in advance.

futtta commented 5 years ago

The problem is that AOCCSS is built to integrate with criticalcss's rest/json-like remote API. Adding support for other CCSS extractors (of which the first one is by the guy who created criticalcss.com by the way) would require (a) those libraries to also have a remote API and (b) code changes to the plugin to handle the specifics of that (those) other remote API(s). So not very likely (in the short/ mid term at least) I'm afraid @dipiana, sorry.

On Tue, Aug 20, 2019 at 7:41 PM Clemens notifications@github.com wrote:

I absolutely love your plugin(s), such amazing work. Just came across the critical CSS plugin which I found very interesting. Unfortunately, the monthly pricing adds up when you want to use it on many pages.

What do you think about adding the option to use a different / open source service to extract critical CSS?

There are some promising libraries on GitHub more advanced users could setup on their own servers and then use with your plugin.

For example: https://github.com/pocketjoso/penthouse https://github.com/stereobooster/react-snap https://github.com/addyosmani/critical

I think it would be an enormous benefit for many people (including me).

Highly appreciate your work.

Thanks in advance.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/futtta/ao_critcss_aas/issues/113?email_source=notifications&email_token=AABMIMO4JNAA2SDTQKJNN23QFQUEZA5CNFSM4IN2Q7IKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HGJ47BA, or mute the thread https://github.com/notifications/unsubscribe-auth/AABMIMINSEZ5OROGGMSZKXLQFQUEZANCNFSM4IN2Q7IA .

dipiana commented 5 years ago

Okay I see - thanks none the less! :-)