search

futtta / ao_critcss_aas

Autoptimize power-up to integrate with criticalcss.com
9 stars 1 forks source link

GET response interpreted as UNKOWN when validationStatus == SCREENSHOT_WARN_BLANK #117

Closed futtta closed 5 years ago

futtta commented 5 years ago

will probably have to be considered R but used iso being forgotten as U. @pocketjoso agreed?

pocketjoso commented 5 years ago

U meant it was never used, is that correct? Then yes, I think R is more appropriate, as we have discussed in other contexts. Even though I would really want everyone in this case to understand and fix the underlying issue, as we've said the truth is that even without doing so they can still get a performance improvement, albeit smaller - so let's give them that.

futtta commented 5 years ago

but what does SCREENSHOT_WARN_BLANK mean; that you weren't able to validate the result? and what would the underlying issue be?

pocketjoso commented 5 years ago

I hear we need documentation on this. :) It means that the site in question does not show any content until JS loads. (the first render with critical css is blank).

futtta commented 5 years ago

OK, so while I'm at it; any other non-default validationStatus'es we should also consider result in R jobs instead of silently but utterly failing?