search

futtta / ao_critcss_aas

Autoptimize power-up to integrate with criticalcss.com
9 stars 1 forks source link

manual conditional rule becoming auto rule, overwriting CCSS #25

Closed futtta closed 6 years ago

futtta commented 6 years ago

As observed by a user and confirmed on my blog;

  1. create a manual rule for is_front_page conditional tag, add CCSS and submit
  2. manual rule is successfully created
  3. go back some time later (I guess after the next queue run) and the manual rule is auto + the original CCSS got overwritten.

This is probably a regression due to https://github.com/futtta/ao_critcss_aas/issues/22

denydias commented 6 years ago

There was a regression, yes. Fixed in the above commit.

Just to make sure: are ou saving changes after creating the rule? By not saving changes, rules just created appear in UI but are not persisted and a cron job could create an auto one instead. They could look like 'overridden' to the user.

Just by submitting the rule dialog is not enough. One must hit 'save changes' button in the main UI.

futtta commented 6 years ago

"always saving", yes. we might want to improve on that by doing some ajaxy stuff one day ... I'll add this idea as an issue so we don't forget about it.

On Fri, Apr 13, 2018 at 9:22 AM, Deny Dias notifications@github.com wrote:

There was a regression, yes. Fixed in the above commit.

Just to make sure: are ou saving changes after creating the rule? By not saving it, rules are not persisted and they could look like 'overridden' to the user.

Jut by submitting the rule dialog is not enough. One must hit 'save changes' button in the main UI.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/futtta/ao_critcss_aas/issues/25#issuecomment-381047814, or mute the thread https://github.com/notifications/unsubscribe-auth/AALEMePIQ_iFJPsxvNwtxgNetxI8k6sTks5toFI4gaJpZM4TOSRT .

denydias commented 6 years ago

I knew this day was coming... :wink: