search

futtta / ao_critcss_aas

Autoptimize power-up to integrate with criticalcss.com
9 stars 1 forks source link

advanced option; force noptimize #33

Closed futtta closed 6 years ago

futtta commented 6 years ago

in some (very) rare cases ccss.com has issues parsing AO's CSS, in which case having an (advanced) option to force the plugin to feed ccss.com a URL with ?ao_noptimize=1 appended to the to be CCSS'ed URL would make sense.

futtta commented 6 years ago

tested on my own blog with and without flag, seems to work OK. @denydias would you care to do a quick review of https://github.com/futtta/ao_critcss_aas/commit/fca6a641d218cb036c7150cda2914de91f68304b to make sure I didn't do anything stupid? :-)

denydias commented 6 years ago

You've forgot the export/import features. I'll fix that until monday.

futtta commented 6 years ago

Should be OK now :grin:

denydias commented 6 years ago

Yeap!

Anyway, I'll provide translations. Is this very urgent? Tag 1.2.0?

futtta commented 6 years ago

nah, not urgent :-)

tag it as 1.1.1, it's not important enough for 1.2.0 ;-)

On Sun, May 27, 2018 at 7:19 AM, Deny Dias notifications@github.com wrote:

Yeap!

Anyway, I'll provide translations. Is this very urgent? Tag 1.2.0?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/futtta/ao_critcss_aas/issues/33#issuecomment-392306064, or mute the thread https://github.com/notifications/unsubscribe-auth/AALEMertla7SfuKv8reZl-DOgo7sX-Sxks5t2jddgaJpZM4UGoC4 .

denydias commented 6 years ago

We're using semantic versioning to tag. There are no important or unimportant features. There are only features that brakes or not the API, and patches. This one is a backwards-compatible feature, so it worth a 1.2.0 tag.

What I mean by asking is if this feature should be part of 1.2.0 alone or do you want to include any other feature. Do you?

futtta commented 6 years ago

let's wait until I'm sure, looking into the commercial texts today/ tomorrow.

On Sun, May 27, 2018 at 8:29 AM, Deny Dias notifications@github.com wrote:

Assigned #33 https://github.com/futtta/ao_critcss_aas/issues/33 to @futtta https://github.com/futtta.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/futtta/ao_critcss_aas/issues/33#event-1648112371, or mute the thread https://github.com/notifications/unsubscribe-auth/AALEMQXjH0Ci4-BHVoao0_cGKZVIgZ8Jks5t2kfOgaJpZM4UGoC4 .

denydias commented 6 years ago

Done with translation. Also changed the logic to add the query string parameter a little bit and did some cleanup.

futtta commented 6 years ago

Obrigado Deny!

denydias commented 6 years ago

Graag gedaan, Frank!

futtta commented 6 years ago

ready for tagging mate :)

denydias commented 6 years ago

Done. :wink: