futtta / ao_critcss_aas

Autoptimize power-up to integrate with criticalcss.com
9 stars 1 forks source link

inc/core.php: match path with urldecoded $_SERVER['REQUEST_URI']? #54

Closed futtta closed 6 years ago

futtta commented 6 years ago

cfr. https://wordpress.org/support/topic/full-css-not-critical-in-body-of-the-html-document/#post-10556934

user had path-based rules with cyrillic characters which did not match, he converted them to urlencoded strings and it did work, so maybe we should urldecode($_SERVER['REQUEST_URI']) in the path-based logic in inc/core.php

makes sense to you @denydias or am I forgetting something here?

denydias commented 6 years ago

Sorry for the late reply, @futtta. Yes, urldecode() should be enough for that use case.