search

futtta / ao_critcss_aas

Autoptimize power-up to integrate with criticalcss.com
9 stars 1 forks source link

review job submission logic #57

Closed futtta closed 6 years ago

futtta commented 6 years ago

just a hunch, to be confirmed; if 2 (or more) 'N' jobs are in the queue, both of e.g. is_single and both with the same new hash (so is_single in rules has diff. hash), then both jobs result in a submission to ccss.com?

denydias commented 6 years ago

Yes. If the new N jobs were placed into the queue at the same cron interval, the queue logic will fire requests for both.

futtta commented 6 years ago

thanks for confirming, saves me some time :-)

On Fri, Aug 17, 2018 at 10:04 AM, Deny Dias notifications@github.com wrote:

Yes. If the new N jobs were placed into the queue at the same cron interval, the queue logic will fire requests for both.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/futtta/ao_critcss_aas/issues/57#issuecomment-413790256, or mute the thread https://github.com/notifications/unsubscribe-auth/AALEMf3gEMoQDArL8s4C1zMvBunTmVP5ks5uRnkegaJpZM4V9n36 .

futtta commented 6 years ago

tested and looks OK, does https://github.com/futtta/ao_critcss_aas/commit/6c0ac3b004b447a3d6ab393b1009d05c3c1dfe08 indeed make sense to you @denydias ?

futtta commented 6 years ago

@pocketjoso; this is active on blog.futtta.be, you should start seeing less requests for that domain.

denydias commented 6 years ago

@futtta, yes, it does. Just remove that global $ao_ccss_queue; from step 3 to avoid loading the queue object twice and you're done.

futtta commented 6 years ago

errr ... but ao_ccss_diff_hashes() does not have access to $ao_ccss_queue yet (same as for $ao_ccss_rules; a couple of lines lower)?

On Fri, Aug 17, 2018 at 9:19 PM, Deny Dias notifications@github.com wrote:

@futtta https://github.com/futtta, yes, it does. Just remove that global $ao_ccss_queue; from step 3 to avoid loading the queue object twice and you're done.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/futtta/ao_critcss_aas/issues/57#issuecomment-413964307, or mute the thread https://github.com/notifications/unsubscribe-auth/AALEMWQhtszBKEWnOvq_C1WT-iA4tDu-ks5uRxdEgaJpZM4V9n36 .

denydias commented 6 years ago

Oh! My bad! I've read $ao_ccss_queue twice (after steps 2 and 3 comments). Never mind. :stuck_out_tongue_closed_eyes: