rules panel UI improvements?

futtta / ao_critcss_aas

Autoptimize power-up to integrate with criticalcss.com

9 stars 1 forks source link

rules panel UI improvements? #61

Open futtta opened 6 years ago

futtta commented 6 years ago

make path vs types collapsable?
make rules sortable (separately path vs types)?
a search (esp. handy for AUTO generated path-based rules?

denydias commented 6 years ago

What you mean by paths vs types?

A JS search is going to feeze the UI in huge sites. Default CTRL+F behavior is more than enough for a good string search, no?

pocketjoso commented 6 years ago

A JS search is going to feeze the UI in huge sites. Default CTRL+F behavior is more than enough for a good string search, no?

As long as you're not nesting your iterations over data, this is not true. (it would be very fast, to perform the search itself. Then you have to update the UI, but I presume this would be OK too. If it's too slow to do on ~keydown, it can just be done on the press of a button instead.)

futtta commented 6 years ago

added some classes to be able to target all PATHS or TYPES rules with CSS (or jQuery), see https://github.com/futtta/ao_critcss_aas/commit/ac0af8a5f614b3d16bcffcf20a1ae2c0aa41b793 but no UI changes at this point.