search

futtta / ao_critcss_aas

Autoptimize power-up to integrate with criticalcss.com
9 stars 1 forks source link

set request limit to 5 by default? #87

Closed futtta closed 5 years ago

pocketjoso commented 5 years ago

What would be the benefit here, over the current request limit (which is 2)?

futtta commented 5 years ago

no, by default there is no request limit, which could see (and does see in some cases) the queue processing job killed (with the queue lock remaining, blocking queue processing until the lock is forcefully removed by the twice-daily cleanup job).

On Wed, Feb 6, 2019 at 5:35 PM Jonas Ohlsson Aden notifications@github.com wrote:

What would be the benefit here, over the current request limit (which is 2)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/futtta/ao_critcss_aas/issues/87#issuecomment-461091286, or mute the thread https://github.com/notifications/unsubscribe-auth/AALEMfsXrDVt0Pwp6G4LITMga4TMSj5Eks5vKwRLgaJpZM4alPsv .

pocketjoso commented 5 years ago

Ah see. The Criticalcss.com API enforces a limit of max two concurrect generate requests per domain, I confused this with what you're talking about here. Okay then. :)