search

futtta / wp-youtube-lyte

Embed YouTube on WordPress for optimal performance
24 stars 10 forks source link

Allow editing disclaimer text in code #26

Closed pjrobertson closed 3 years ago

pjrobertson commented 3 years ago

The lyte_disclaimer is passed through wp_kses_data (very sensible) to remove any unwanted text/code.

However this means there is currently no way to add any text to the lyte_disclaimer block, without hacking the code. I propose adding a filter to allow themes/other functions to edit the text.

Use case: in my case I want to add a small icon to the end of each lyte_disclaimer block. But images are removed by wp_kses_data

futtta commented 3 years ago

this fits in the "why not" category ;-)

thanks!

pjrobertson commented 3 years ago

Speedy merge, thanks!

pjrobertson commented 3 years ago

@futtta any chance you can get a new release out with this change in the next week? Waiting on this to update our site. Thanks!

futtta commented 3 years ago

sorry for the delay, pushed out 1.7.17 just now Patrick.

On 13/10/2021 05:34, Patrick Robertson wrote:

@futtta https://github.com/futtta any chance you can get a new release out with this change in the next week? Waiting on this to update our site. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/futtta/wp-youtube-lyte/pull/26#issuecomment-941885552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABMIMOXFFGCW2F5Q7LHJODUGT43DANCNFSM5E2DXDHA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

pjrobertson commented 3 years ago

Great, thanks! Appreciate this :)

On Saturday, 13 November 2021, frank goossens @.***> wrote:

sorry for the delay, pushed out 1.7.17 just now Patrick.

On 13/10/2021 05:34, Patrick Robertson wrote:

@futtta https://github.com/futtta any chance you can get a new release out with this change in the next week? Waiting on this to update our site. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/futtta/wp-youtube-lyte/pull/26# issuecomment-941885552, or unsubscribe https://github.com/notifications/unsubscribe-auth/ AABMIMOXFFGCW2F5Q7LHJODUGT43DANCNFSM5E2DXDHA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct= notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com. github.android&referrer=utm_campaign%3Dnotification-email% 26utm_medium%3Demail%26utm_source%3Dgithub.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/futtta/wp-youtube-lyte/pull/26#issuecomment-968078168, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABEXHZNTAVOVWOJZLDGC73ULZZULANCNFSM5E2DXDHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.