Alignment options from Gutenberg

futtta / wp-youtube-lyte

Embed YouTube on WordPress for optimal performance

24 stars 10 forks source link

Alignment options from Gutenberg #38

Closed benjaminpick closed 3 months ago

benjaminpick commented 1 year ago

Fix #16

[x] Parse out the align property
[x] format the align property via css
[x] add additional classes

futtta commented 3 months ago

sorry for the delay @benjaminpick !

to be honest I would prefer to refactor the code mess LYTE currently is to e.g. act on the <iframe` tag at a later stage (which could/ should allow Gutenberg alingment to be honored) and not use the YT API any more and use better lazy loading of the thumbnail and ...

but as I don't have the time, so I'll happily merge your changes.

do you happen to have your changes running on a production site somewhere already (which we could consider a good test)?

benjaminpick commented 3 months ago

Yes it's working on my production site.

futtta commented 3 months ago

would you care to share the URL Benjamin (here or in a mail to futtta-at-gmail-dot-com)?

benjaminpick commented 2 months ago

https://families-in-ministry.com/online-course/ - there is a centered video in the middle of the page. I updated the plugin to the current github version.