future-application-laboratory / BirthReminder

The tool that helps you manage your favorite ACGN characters’ birthdays
https://birthreminder.fal.moe
GNU Affero General Public License v3.0
18 stars 2 forks source link

Cache Images? #14

Open ApolloZhu opened 6 years ago

ApolloZhu commented 6 years ago

Using libraries like Kingfisher?

uetcis commented 6 years ago

I'll take it on board

uetcis commented 6 years ago

Well, after careful consideration, I've found it a bit hard to use KingFisher to load images. Here is the reason:

ApolloZhu commented 6 years ago

Some thoughts:

uetcis commented 6 years ago

Actually, every character/anime in the database has a unique key, so that we can get identifiers for free.

ApolloZhu commented 6 years ago

The implementation I can think of for now will require changing the backend to only return the base64 image when required or the image has been updated...

uetcis commented 6 years ago

In my opinion, the copyright info should be cached together with the image data. We can make a specific model for caching the whole PicPack

ApolloZhu commented 6 years ago

LGTM