search

future-architect / cheetah-grid

The fastest open-source data table for web.
https://future-architect.github.io/cheetah-grid/
MIT License
1.44k stars 116 forks source link

Move react and react-dom to peerDependencies from dependencies #419

Closed acherkashin closed 4 months ago

acherkashin commented 4 months ago

Recently we've decided to use React version of cheetah-grid as we previously used a vanilla version, it works perfectly for us 👍

We are using react 18, and noticed in pnpm-lock.yaml appeared react-17.

image

I've looked at package.json of cheetah-grid-react and noticied that react is specified as dependency there https://github.com/future-architect/cheetah-grid/blob/bb08d463afa1b0d0ead4ad22be18f09ac98b9ff6/packages/react-cheetah-grid/package.json#L25

I think we should specify react as peerDependency instead. Moreover, we should allow react version >= 17.

ota-meshi commented 4 months ago

@shibukawa Is it possible to change dependencies?

acherkashin commented 4 months ago

@ota-meshi do you want me to send a pull request?

ota-meshi commented 4 months ago

Yeah! Pull requests are welcome. Thank you.

acherkashin commented 4 months ago

@ota-meshi I've created pull request https://github.com/future-architect/cheetah-grid/pull/420