future-architect / vuls

Agent-less vulnerability scanner for Linux, FreeBSD, Container, WordPress, Programming language libraries, Network devices
https://vuls.io/
GNU General Public License v3.0
10.8k stars 1.16k forks source link

fix(scanner/suse): skip new line in zyper -q lu #1986

Closed MaineK00n closed 5 days ago

MaineK00n commented 5 days ago

If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.

What did you implement:

Fixes #1977

Type of change

How Has This Been Tested?

setup

$ git clone https://github.com/MaineK00n/vuls-targets.git
$ cd vuls-targets/suse/leap/15.6
$ vagrant up --provision
// TODO: add known_hosts

$ cat config.toml
[servers.vagrant]
host = "127.0.0.1"
port = "2222"
user = "vagrant"
keyPath = "/home/vuls/vuls-targets/.ssh/id_rsa"
scanMode           = ["fast-root"]
scanModules        = ["ospkg"]

before

$ vuls scan
[Jul  4 14:57:44]  INFO [localhost] vuls-v0.26.0-build-20240704_144346_ac55380
...
[Jul  4 14:57:47]  INFO [localhost] (1/1) vagrant is running on other
[Jul  4 14:57:47]  INFO [vagrant] Scanning OS pkg in fast-root mode
[Jul  4 14:57:48]  WARN [vagrant] err: Failed to scan updatable packages:
    github.com/future-architect/vuls/scanner.(*suse).scanPackages
        /home/mainek00n/github/github.com/MaineK00n/vuls/scanner/suse.go:192
  - zypper -q lu Unknown format: :
    github.com/future-architect/vuls/scanner.(*suse).parseZypperLUOneLine
        /home/mainek00n/github/github.com/MaineK00n/vuls/scanner/suse.go:249
[Jul  4 14:57:50]  WARN [localhost] Some warnings occurred during scanning on vagrant. Please fix the warnings to get a useful information. Execute configtest subcommand before scanning to know the cause of the warnings. warnings: [Failed to scan updatable packages:
    github.com/future-architect/vuls/scanner.(*suse).scanPackages
        /home/mainek00n/github/github.com/MaineK00n/vuls/scanner/suse.go:192
  - zypper -q lu Unknown format: :
    github.com/future-architect/vuls/scanner.(*suse).parseZypperLUOneLine
        /home/mainek00n/github/github.com/MaineK00n/vuls/scanner/suse.go:249]

Scan Summary
================
vagrant opensuse.leap15.6   275 installed, 0 updatable

Warning: [Failed to scan updatable packages:
    github.com/future-architect/vuls/scanner.(*suse).scanPackages
        /home/mainek00n/github/github.com/MaineK00n/vuls/scanner/suse.go:192
  - zypper -q lu Unknown format: :
    github.com/future-architect/vuls/scanner.(*suse).parseZypperLUOneLine
        /home/mainek00n/github/github.com/MaineK00n/vuls/scanner/suse.go:249]

To view the detail, vuls tui is useful.
To send a report, run vuls report -h.

after

$ vuls scan
[Jul  4 14:59:39]  INFO [localhost] vuls-v0.26.0-build-20240704_145807_67df9ce
...
[Jul  4 14:59:41]  INFO [localhost] (1/1) vagrant is running on other
[Jul  4 14:59:41]  INFO [vagrant] Scanning OS pkg in fast-root mode

Scan Summary
================
vagrant opensuse.leap15.6   275 installed, 122 updatable

To view the detail, vuls tui is useful.
To send a report, run vuls report -h.

Checklist:

You don't have to satisfy all of the following.

Is this ready for review?: YES

Reference