Closed isacoder closed 6 months ago
This PR is an update request of the Issue https://github.com/future-standard/scorer-ui-kit/issues/439
Right now midnight is not correctly reflected in the text of filter results input
24:00 is shown as 23:59 the request is to show the next day at 00:00
The format sent by the user might influence the output but that is related to date-fns and should be handled by the Developer using UI Kit
yyyy-MM-dd HH:MM will show 2024-03-14 00:03 - 2024-03-15 00:03
yyyy-MM-dd HH:mm while using minutes lowercase will show 2024-03-14 00:01 - 2024-03-15 00:00
Out of the scope of this PR is to fix the DatePicker wrong Dates related to 24 hours
Currently when the user updates the date to 24:00 the value is received as 23:00 by the developer.
This will be fix in a different PR.
Run storybook in local
On FilterBar story select in the second clock 24:00 of any Date.
This is the happy path but like I mentioned before error in the callback are present when the user updates to 24 hours manually
https://drive.google.com/file/d/1Cs3JiClLQh_yoREZLWyaWwj76dcazPBi/view?usp=drive_link
Description
This PR is an update request of the Issue https://github.com/future-standard/scorer-ui-kit/issues/439
Right now midnight is not correctly reflected in the text of filter results input
24:00 is shown as 23:59 the request is to show the next day at 00:00
Considerations on Implementation
The format sent by the user might influence the output but that is related to date-fns and should be handled by the Developer using UI Kit
yyyy-MM-dd HH:MM will show 2024-03-14 00:03 - 2024-03-15 00:03
yyyy-MM-dd HH:mm while using minutes lowercase will show 2024-03-14 00:01 - 2024-03-15 00:00
Out of the scope of this PR is to fix the DatePicker wrong Dates related to 24 hours
Currently when the user updates the date to 24:00 the value is received as 23:00 by the developer.
This will be fix in a different PR.
Reviewing/Testing steps
Run storybook in local
On FilterBar story select in the second clock 24:00 of any Date.
Video
This is the happy path but like I mentioned before error in the callback are present when the user updates to 24 hours manually
https://drive.google.com/file/d/1Cs3JiClLQh_yoREZLWyaWwj76dcazPBi/view?usp=drive_link