search

futureaus / servue

Server-side rendering engine that renders vue files into html strings
https://futureaus.github.io/servue
59 stars 3 forks source link

Errors during installation #25

Closed nick-fytros closed 5 years ago

nick-fytros commented 5 years ago

Hello,

I want to start by saying your package looks very interesting. I created a sample project in order to try the expressjs setup and after installing the base packages I got the errors below:

and some errors on no closing tags on the slots in the template part but I intend on opening a PR to fix some examples. Is it required on purpose to install vue-server-renderer, vue-template-compiler and vue in our project and so they are not included in the package? If so that needs to be added to the docs.

nick-fytros commented 5 years ago

Actually I just noticed that they are listed as peer dependencies. So I guess they are not included on purpose and that would make sense because then you can control the vue dependencies in your own project. Still it would probably be nice to list that in the README. Also the PR is ready for the slot and some other minor changes. https://github.com/futureaus/servue/pull/26

AlbertMarashi commented 5 years ago

That's correct, they are peer-dependencies. I made it that way so that users can control their Vue version.

I should probably ad that to the docs.

AlbertMarashi commented 5 years ago

Fixed with 034d530