search

futurechan / gulp-asset-transform

13 stars 3 forks source link

Create stream for concat instead of using a string #3

Closed futurechan closed 9 years ago

futurechan commented 9 years ago

By using the stream function strategy, this is already supported. However, we should deprecate the magic 'concat' string in favor of a special concat object for the tasks array strategy.

danilo-valente commented 9 years ago

I personally like 'concat' but I see no problem in adding a at.concat() method that returns concat(outputFilename), where outputFilename is the name of the file defined in the block.

danilo-valente commented 9 years ago

I've implemented that at.concat method, please check it here. If that's what you meant, I'll open a PR.

futurechan commented 9 years ago

Looks good.