search

futurefirst / uk.org.futurefirst.networks.civipoints

An extension for CiviCRM. Allows points to be allocated to contacts.
Other
1 stars 6 forks source link

If a contact has no points of one type, but has points of another type, no tabs show #8

Closed davidknoll closed 8 years ago

davidknoll commented 8 years ago

Suppose there are 3 types of points. A contact has never had any points of type 1 but has some of type 2 and some of type 3. None of the tabs show up.

If some points of type 1 are then granted to the contact, all the tabs show up.

davidknoll commented 8 years ago

The hook civipoints_civicrm_tabs is bombing out early. There is a return that should be a continue when checking whether a contact has had points of each type.

JohnFF commented 8 years ago

@davidknoll In my view - this is the wrong approach to showing the tab. I think that points should be connected to a type of contact (i.e. Student, School) and then display for contacts of that type regardless of if points have been added or not.

Just an opinion :)

davidknoll commented 8 years ago

I think we talked about that at the sprint, it's already a future enhancement: https://github.com/futurefirst/uk.org.futurefirst.networks.civipoints/issues/5

JohnFF commented 8 years ago

So it is - nice one!

On Fri, Nov 20, 2015 at 4:06 PM, David Knoll notifications@github.com wrote:

I think we talked about that at the sprint, it's already a future enhancement: #5 https://github.com/futurefirst/uk.org.futurefirst.networks.civipoints/issues/5

— Reply to this email directly or view it on GitHub https://github.com/futurefirst/uk.org.futurefirst.networks.civipoints/issues/8#issuecomment-158444638 .