search

futurelearn / squiddy

Github Actions bot
1 stars 1 forks source link

Use the Alpine Ruby image #15

Closed surminus closed 3 years ago

surminus commented 3 years ago

The difference in size is ~850MB vs ~50MB; this is because the standard base image is built on a very chunky Ubuntu base image. Given this has to be built each time, it would be much quicker to build it using the much smaller image.

ub8hur9Cob4xeeGei0je commented 3 years ago

The code change looks fine to me but the github actions error does not. It looks like it is trying and failing to push the tagged image to dockerhub and is failing. Has this job fallen foul of our container repository changes? I am assuming that we can ignore the deprecation warning, that seems to be urging us to use docker/build-push-action@v2 in place of docker/build-push-action@v1.

surminus commented 3 years ago

We don't actually need the Docker image to be built since GitHub Actions does not use a pre-built image, it builds it on demand. So I'm inclined to delete this push completely.

surminus commented 3 years ago

Gone ahead and added a commit that does just that :)