search

futurelearn / squiddy

Github Actions bot
1 stars 1 forks source link

Update bubble_merge.yml #25

Closed MatMoore closed 2 years ago

MatMoore commented 2 years ago

Currently when a comment is edited, github actions will not check to see if the edited comment contains "@squiddybot merge".

This means that if you make a typo and edit your comment, nothing will happen, which is a bit counterintuitive.

This commit extends bubble merge to edited comments. If the comment does not contain "@squiddybot merge" the workflow is triggered, but the job is skipped, the same as when adding a new comment.

Previously: https://github.com/futurelearn/futurelearn/pull/11725

MatMoore commented 2 years ago

@squiddy-bot merge

MatMoore commented 2 years ago

@squiddy-bot merge

MatMoore commented 2 years ago

Oh, we are missing the token in this repo: Input required and not supplied: github-token

MatMoore commented 2 years ago

This might be an issue with running actions on push on a public repo.

I'm just merging this as is for now, we can sort out this issue with the workflow configuration separately.

home simpson retreating into the bushes