search

futurepress / epub.js

Enhanced eBooks in the browser.
http://futurepress.org
Other
6.3k stars 1.08k forks source link

Is `ignoreClass` value within the examples outdated? #1370

Open santiagos01 opened 5 months ago

santiagos01 commented 5 months ago

Noticed that the value for ignoreClass within the examples is annotator-hl (e.g., in highlights.html). However, it seems that the default class name for highlighting is epubjs-hl (source). Are the examples outdated?

johnfactotum commented 5 months ago

I could be wrong but I believe the annotator-hl class is for the Hypothesis Client only. For highlights created by Epub.js, they are not injected into the content so there's nothing to ignore.