search

futurepress / epubjs-angular-reader

ePub.js Reader
Other
122 stars 37 forks source link

Book root not maintained in URL #19

Open dwhly opened 10 years ago

dwhly commented 10 years ago

After a few pages, this: http://oerpub.github.io/sf-demo-book/reader/

Becomes this: http://oerpub.github.io/6/4%5Buntitled-e674b181-6d52-4d49-b97b-931362ab6625.html%5D!/2/4/28

Bad! :)

alerque commented 7 years ago

You can fix the part about not maintaining the root path in the HTML for your reader by setting the base path:

<base href="/sf-demo-book/reader/">

Unfortunately this only fixes part of the problem. You also need some way to pass the location fragments back into the reader, and I haven't figured out that part yet.

fchasen commented 7 years ago

Ek, yes something pretty funky is going on there, I'll take a peak this week.

This angular version of the reader is sadly very out of date. The demo reader here is updated more frequently: https://github.com/futurepress/epub.js/tree/master/reader

I need to move the demo out of the main repo and start to update this one more frequently soon.

alerque commented 7 years ago

@fchasen This is roughly the issue I asked about it Gitter a day or two ago. Am I reading you right that I should probably not be using this repo at all and instead figure out how to run directly from the epub-js project? I have to real reason to us Angular except this repo seemed like an easier point of entry. If its buggy and out of date in relation to the main project I should probably just figure out how to get that running on a page of my own, no?