search

futuretap / InAppSettingsKit

This iOS framework allows settings to be in-app in addition to or instead of being in the Settings app.
https://www.futuretap.com/blog/inappsettingskit-3-0
Other
3.18k stars 544 forks source link

InAppSettingsKit broken for SPM integrations on XCode 13-beta3 #456

Closed scannillo closed 2 years ago

scannillo commented 2 years ago

In the XCode 13-beta3 release notes, you can see this change was made to SPM:

Linking Swift packages from application extension targets or watchOS applications no longer emits unresolvable warnings about linking to libraries not safe for use in application extensions. This means that code referencing APIs annotated as unavailable for use in app extensions must now themselves be annotated as unavailable for use in application extensions, in order to allow that code to be used in both apps and app extensions. (66928265)

My app pulls in InAppSettingsKit via SPM, and I cannot compile due to the following errors coming from the framework:

Screen Shot 2021-07-21 at 10 11 45 AM

An SDK I work on had to also deal with this. You can check out our PR to see how we fixed it.

I am on version 3.1.8 of InAppSettingsKit.

futuretap commented 2 years ago

In 3.3.2, I annotated with NS_EXTENSION_UNAVAILABLE where needed. However, the issue still seems to occur. Can you verify? Can't find any advice how to fix this problem.

futuretap commented 2 years ago

After cleaning derived data it looks like it is fixed indeed.

scannillo commented 2 years ago

Hello - thank you for getting this fix out so quickly! Much appreciated.