This iOS framework allows settings to be in-app in addition to or instead of being in the Settings app.
3.18k
stars
545
forks
source link
Make property `File` (which represents the URL) from `IASKAppSettingsWebViewController` localizable #510
Open
funnel20 opened 2 hours ago
While migrating my apps to InAppSettingsKit 3.8.3 with the latest changes to
IASKAppSettingsWebViewController
, I stumble to a localization issue:For an instance I use a localised URL from the *.strings files. My custom WebViewController did handle this well by using
NSLocalizedString()
:However, IASKAppSettingsWebViewController crashes at: https://github.com/futuretap/InAppSettingsKit/blob/b6d44e1235d35c6bfb95b884b1e8975718f16ef9/Sources/InAppSettingsKit/Controllers/IASKAppSettingsViewController.m#L895
when
specifier.file
is no valid URL, but a localization string (e.g.loginUrl
).