search

futureverse / parallelly

R package: parallelly - Enhancing the 'parallel' Package
https://parallelly.futureverse.org
130 stars 7 forks source link

Preparing for removal of RSTUDIO_MSYS_SSH #116

Closed kevinushey closed 2 weeks ago

kevinushey commented 1 month ago

The version of ssh.exe bundled with RStudio on Windows is now quite old, and we're considering removing it in a future release. We'd then like to rely on the versions of ssh.exe bundled with Windows, or otherwise direct users to download an SSH client themselves (or even use the one provided as part of Git for Windows).

I see parallely tries to make use of this SSH client if available:

https://github.com/HenrikBengtsson/parallelly/blob/199705bfa3957112c4c85bcff6a62f93fcff241f/R/utils%2Ccluster.R#L115-L132

Is this going to cause trouble for parallely, or are you able to rely on other available SSH installations?

HenrikBengtsson commented 2 weeks ago

Thanks for the heads-up. Everything will keep working as usual, because parallelly [searches among several alternatives when on Windows;

https://github.com/HenrikBengtsson/parallelly/blob/4a3e668673a7e9d88b42920598449fb921d9cc42/R/utils%2Ccluster.R#L164-L166

and the RStudio one is the last. It should pick up ssh on Windows (>= 10), and if RStudio doesn't have one, it'll conclude SSH is not available.