futurewei-cloud / alcor-control-agent

Cloud native SDN platform - network control agent
MIT License
14 stars 29 forks source link

Add ovs routing rule for router and subnet #257

Closed DavidLiu506 closed 3 years ago

DavidLiu506 commented 3 years ago

Hi Rio, It has neighbors which routing rule needed. It faster than look up new_subnet_routing_table_entry which includes all neighbors. Also in GoalStateV2, not all neighbors which routing rule needed are included in new_subnet_routing_table_entry and that is why DPM send them to ACA.

DavidLiu506 commented 3 years ago

Also, alcor control agent insert neighbors after RouterState so new_subnet_routing_table_entry might not include all neighbors.

Thanks for your review @zzxgzgz

zzxgzgz commented 3 years ago

Hi Rio, It has neighbors which routing rule needed. It faster than look up new_subnet_routing_table_entry which includes all neighbors. Also in GoalStateV2, not all neighbors which routing rule needed are included in new_subnet_routing_table_entry and that is why DPM send them to ACA.

Sounds good, if DPM will send all the needed neighbor states with the router state, that should be good. Thank you Dahai.