search

futurewei-cloud / alcor-control-agent

Cloud native SDN platform - network control agent
MIT License
14 stars 29 forks source link

Add listeners for mulitcast and unicast consumers #268

Closed luyaoluo closed 2 years ago

luyaoluo commented 3 years ago

This is the PR for pulsar client implementation on aca based on the previous designs.

zzxgzgz commented 3 years ago

Thank you for submitting this PR @lly00,

could you please share the test results, if any, with the community? That will help us a lot in the reviewing process.

Thank you.

luyaoluo commented 3 years ago

Thank you for submitting this PR @lly00,

could you please share the test results, if any, with the community? That will help us a lot in the reviewing process.

Thank you.

OK, but what kind of test results do we need? Are the test results of gtests or just of pulsar client?

zzxgzgz commented 3 years ago

Thank you for submitting this PR @lly00, could you please share the test results, if any, with the community? That will help us a lot in the reviewing process. Thank you.

OK, but what kind of test results do we need? Are the test results of gtests or just of pulsar client?

The gtest results will be great. Also, I noticed that the listener function can receive GoalState messages before it calls rc = Aca_Comm_Manager::get_instance().update_goal_state( deserialized_GoalState, gsOperationalReply);. Can you please post the results of that function being called? It will be great to see the pulsar consumer is able to receive GoalState and update GoalState successfully.

Thank you.

luyaoluo commented 2 years ago

@zzxgzgz We have add some test cases for pulsar consumer, which send a goalstate to create a port. The pulsar consumer is able to receive GoalState and update GoalState successfully. However, it does not support goalstateV2 currently. Besides, some test cases in aca_tests can not pass. image

zzxgzgz commented 2 years ago

@zzxgzgz We have add some test cases for pulsar consumer, which send a goalstate to create a port. The pulsar consumer is able to receive GoalState and update GoalState successfully. However, it does not support goalstateV2 currently. Besides, some test cases in aca_tests can not pass. image

Thank you for your update.

For this PR, adding support to GoalState(V1) should be good enough.

Can you please provide some kind of test result of the GoalState, just like the screenshot you provided for the GoalStateV2 tests? So that we can confirm that the GoalState was successfully sent to ACA via this pulsar channel.

Thank you.

luyaoluo commented 2 years ago

There are the results for GoalStateV2 tests, whicih are in gtests. producer: 9acdcf339b9373708422f34ad71a206 consumer: 589a4d206b4c36075bcd635497348d1

zzxgzgz commented 2 years ago

There are the results for GoalStateV2 tests, whicih are in gtests. producer: 9acdcf339b9373708422f34ad71a206 consumer: 589a4d206b4c36075bcd635497348d1

Thank you for your update. Looks like that the Pulsar is now able to receive GoalStateV2 messages.