futurewei-cloud / alcor

Alcor: Cloud native SDN platform powered by Kubernetes and Istio
MIT License
32 stars 33 forks source link

[Contract] Support Port Delete and Preliminary Support of Zeta GW #467

Closed er1cthe0ne closed 3 years ago

er1cthe0ne commented 3 years ago

The contract change provides support for port delete and adds preliminary Zeta support. The change includes:

  1. added auxiliarygateway.proto to support generic gateways
  2. made AuxGateway generic for all gateways and use "oneof" to store extra info on specific implementation (e.g. zeta).
  3. added device_id and device_owner in proto.proto to support port delete scenario
  4. added auxiliary_gateway at vpc.proto
  5. fix compiler error in DPM because vpc tunnel ID is changed to uint
codecov-io commented 3 years ago

Codecov Report

Merging #467 (f89226d) into master (97a7c17) will increase coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #467      +/-   ##
============================================
+ Coverage     36.53%   36.56%   +0.03%     
- Complexity     1157     1159       +2     
============================================
  Files           452      452              
  Lines         10859    10861       +2     
  Branches       1392     1393       +1     
============================================
+ Hits           3967     3971       +4     
+ Misses         6350     6349       -1     
+ Partials        542      541       -1     
Impacted Files Coverage Δ Complexity Δ
...r/route/service/Impl/NeutronRouterServiceImpl.java 51.49% <0.00%> (+0.29%) 27.00% <0.00%> (+1.00%)
...com/futurewei/alcor/macmanager/utils/MacUtils.java 65.21% <0.00%> (+8.69%) 8.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97a7c17...f89226d. Read the comment docs.

xieus commented 3 years ago

@chenpiaoping This is the PR change we discussed in the open-source meeting today.

chenpiaoping commented 3 years ago

@chenpiaoping This is the PR change we discussed in the open-source meeting today.

ok