futurewei-cloud / alcor

Alcor: Cloud native SDN platform powered by Kubernetes and Istio

MIT License

32 stars 33 forks source link

[Dependency] Upgrade Ignite to 2.9.0 #503

Closed songxiaoyan closed 3 years ago

songxiaoyan commented 3 years ago

Update iginte to 2.9.0

xieus commented 3 years ago

@songxiaoyan Congratulations to your first PR. Short but timely.

xieus commented 3 years ago

You can find the CI failure on this page https://github.com/futurewei-cloud/alcor/pull/503/checks?check_run_id=1491312470. Alternatively, you can click "Details" link on the row of failed Java CI.

You should be able to reproduce the same error on your local machine (following the instructions on https://github.com/futurewei-cloud/alcor/pull/503/checks?check_run_id=1491312470). It is related to Security Group manager.

xieus commented 3 years ago

@chenpiaoping Please review Xiaoyan's PR as well. Thanks.

songxiaoyan commented 3 years ago

@chenpiaoping Please review Xiaoyan's PR as well. Thanks.

You can find the CI failure on this page https://github.com/futurewei-cloud/alcor/pull/503/checks?check_run_id=1491312470. Alternatively, you can click "Details" link on the row of failed Java CI.

You should be able to reproduce the same error on your local machine (following the instructions on https://github.com/futurewei-cloud/alcor/pull/503/checks?check_run_id=1491312470). It is related to Security Group manager.

songxiaoyan commented 3 years ago

You can find the CI failure on this page https://github.com/futurewei-cloud/alcor/pull/503/checks?check_run_id=1491312470. Alternatively, you can click "Details" link on the row of failed Java CI.

You should be able to reproduce the same error on your local machine (following the instructions on https://github.com/futurewei-cloud/alcor/pull/503/checks?check_run_id=1491312470). It is related to Security Group manager.

Okey,I'm looking at this mistake.But I passed the local test before.

codecov-io commented 3 years ago

Codecov Report

Merging #503 (1103fa3) into master (df4df67) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #503   +/-   ##
=========================================
  Coverage     35.64%   35.64%           
  Complexity     1161     1161           
=========================================
  Files           467      467           
  Lines         11311    11311           
  Branches       1456     1456           
=========================================
  Hits           4032     4032           
  Misses         6723     6723           
  Partials        556      556

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df4df67...1103fa3. Read the comment docs.