futurewei-cloud / alcor

Alcor: Cloud native SDN platform powered by Kubernetes and Istio
MIT License
32 stars 33 forks source link

[HotFix] Port Creation Fix in DPM v2.0 #530

Closed chenpiaoping closed 3 years ago

chenpiaoping commented 3 years ago

Fix the port creation failure in DPM v2.0.

codecov-io commented 3 years ago

Codecov Report

Merging #530 (21f0a78) into master (9008390) will increase coverage by 0.07%. The diff coverage is 76.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #530      +/-   ##
============================================
+ Coverage     32.74%   32.82%   +0.07%     
- Complexity     1108     1115       +7     
============================================
  Files           473      473              
  Lines         11751    11772      +21     
  Branches       1514     1521       +7     
============================================
+ Hits           3848     3864      +16     
- Misses         7368     7370       +2     
- Partials        535      538       +3     
Impacted Files Coverage Δ Complexity Δ
.../portmanager/processor/SecurityGroupProcessor.java 54.65% <68.75%> (+3.22%) 17.00 <0.00> (+4.00)
...lcor/portmanager/processor/DataPlaneProcessor.java 63.12% <100.00%> (+0.46%) 30.00 <0.00> (+1.00)
...rewei/alcor/portmanager/processor/PortContext.java 48.64% <100.00%> (+2.16%) 21.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9008390...21f0a78. Read the comment docs.

chenpiaoping commented 3 years ago

@xieus @kevin-zhonghao Please review this PR when you have time.