search

futurewei-cloud / alcor

Alcor: Cloud native SDN platform powered by Kubernetes and Istio
MIT License
32 stars 33 forks source link

Gateway Manager Micorservice #541

Closed songxiaoyan closed 3 years ago

songxiaoyan commented 3 years ago

Current support CREATE,UPDATE,DELETE(for zeta gateway)，continued development based on the design will follow

codecov-io commented 3 years ago

Codecov Report

Merging #541 (9232f36) into master (91e71bd) will decrease coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #541      +/-   ##
============================================
- Coverage     34.95%   34.90%   -0.05%     
+ Complexity     1189     1183       -6     
============================================
  Files           473      473              
  Lines         11799    11799              
  Branches       1526     1526              
============================================
- Hits           4124     4119       -5     
- Misses         7112     7113       +1     
- Partials        563      567       +4
Impacted Files Coverage Δ Complexity Δ
...nager/service/implement/NetworkAclServiceImpl.java 87.73% <ø> (ø) 29.00 <0.00> (ø)
...ewei/alcor/subnet/controller/SubnetController.java 54.18% <ø> (ø) 13.00 <0.00> (ø)
...cor/subnet/service/implement/SubnetServiceImp.java 1.10% <ø> (ø) 1.00 <0.00> (ø)
...com/futurewei/alcor/macmanager/utils/MacUtils.java 56.52% <0.00%> (-8.70%) 7.00% <0.00%> (-1.00%)
...i/alcor/portmanager/processor/RouterProcessor.java 79.41% <0.00%> (-5.89%) 9.00% <0.00%> (-1.00%)
...rewei/alcor/portmanager/processor/PortContext.java 68.91% <0.00%> (-2.71%) 31.00% <0.00%> (-2.00%)
...alcor/elasticipmanager/dao/ElasticIpAllocator.java 63.81% <0.00%> (+0.27%) 48.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91e71bd...9232f36. Read the comment docs.

songxiaoyan commented 3 years ago

@songxiaoyan I cannot find UT codes in this PR. Could you add UT in this PR to verify basic functionalities especially for DB (create/update/delete/query) operations?

I'll make it up as soon as possible