futurewei-cloud / alcor

Alcor: Cloud native SDN platform powered by Kubernetes and Istio
MIT License
32 stars 33 forks source link

[Vpc Mgr] Register and Unregister VPC with GWM #545

Closed songxiaoyan closed 3 years ago

songxiaoyan commented 3 years ago
codecov-io commented 3 years ago

Codecov Report

Merging #545 (cfa2e5e) into master (d1376a9) will decrease coverage by 0.01%. The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #545      +/-   ##
============================================
- Coverage     35.15%   35.13%   -0.02%     
+ Complexity     1227     1226       -1     
============================================
  Files           491      491              
  Lines         12133    12138       +5     
  Branches       1545     1545              
============================================
  Hits           4265     4265              
- Misses         7291     7295       +4     
- Partials        577      578       +1     
Impacted Files Coverage Δ Complexity Δ
.../alcor/vpcmanager/service/Impl/VpcServiceImpl.java 8.82% <0.00%> (-1.18%) 1.00 <0.00> (ø)
...wei/alcor/vpcmanager/controller/VpcController.java 45.77% <100.00%> (+0.38%) 9.00 <0.00> (ø)
...alcor/portmanager/util/RestParameterValidator.java 43.07% <0.00%> (-3.08%) 13.00% <0.00%> (-1.00%)
...alcor/elasticipmanager/dao/ElasticIpAllocator.java 63.81% <0.00%> (+0.27%) 48.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1376a9...cfa2e5e. Read the comment docs.

songxiaoyan commented 3 years ago

@songxiaoyan Most of code look good. Can you add one more function for unregister VPC from Gateway Manager when user delete a VPC. I have already added a workflow for unregister a VPC in the gateway design doc, please refer to https://github.com/cj-chung/alcor/blob/gatewaydesign/docs/modules/ROOT/pages/mgmt_services/gateway_manager.adoc

Ok, I will do it