search

futurewei-cloud / alcor

Alcor: Cloud native SDN platform powered by Kubernetes and Istio
MIT License
32 stars 33 forks source link

[Schema] Protobuf v2 Schema for Network Configuration Manager #551

Closed er1cthe0ne closed 3 years ago

er1cthe0ne commented 3 years ago

This change enabled the new Network Configuration Manager, it includes:

  1. introduce GoalStateV2, so that doesn't break existing GoalState(V1) implementation
  2. updated: rpc PushNetworkResourceStatesStream (stream GoalStateV2) returns (stream GoalStateOperationReply)
  3. new: rpc RequestNetworkConfigurations (NetworkConfigurationsRequest) returns (NCMReply)
  4. deleted: rpc RetrieveNetworkResourceStates (GoalStateRequest) returns (stream GoalState)
codecov-io commented 3 years ago

Codecov Report

Merging #551 (1a334a7) into master (e26b494) will increase coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #551      +/-   ##
============================================
+ Coverage     34.34%   34.38%   +0.03%     
- Complexity     1229     1236       +7     
============================================
  Files           501      501              
  Lines         12365    12398      +33     
  Branches       1558     1567       +9     
============================================
+ Hits           4247     4263      +16     
- Misses         7541     7557      +16     
- Partials        577      578       +1
Impacted Files Coverage Δ Complexity Δ
...wei/alcor/portmanager/service/PortServiceImpl.java 63.25% <0.00%> (-3.89%) 22.00% <0.00%> (+3.00%) :arrow_down:
...alcor/elasticipmanager/dao/ElasticIpAllocator.java 63.53% <0.00%> (-0.28%) 48.00% <0.00%> (ø%)
...portmanager/service/implement/PortServiceImpl.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...lcor/portmanager/processor/DataPlaneProcessor.java 68.29% <0.00%> (+0.79%) 34.00% <0.00%> (+2.00%)
...ortmanager/request/UpdateNetworkConfigRequest.java 80.00% <0.00%> (+2.22%) 4.00% <0.00%> (+1.00%)
...ortmanager/request/CreateNetworkConfigRequest.java 72.72% <0.00%> (+2.72%) 4.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e26b494...1a334a7. Read the comment docs.