futurewei-cloud / alcor

Alcor: Cloud native SDN platform powered by Kubernetes and Istio
MIT License
32 stars 33 forks source link

[Node Metadata Mgr] Add NCM Id field to NodeInfo #563

Closed pkommoju closed 3 years ago

pkommoju commented 3 years ago

NMM changes - part 1

codecov-io commented 3 years ago

Codecov Report

Merging #563 (19a0352) into master (c7baf54) will decrease coverage by 0.00%. The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #563      +/-   ##
============================================
- Coverage     34.38%   34.38%   -0.01%     
- Complexity     1236     1237       +1     
============================================
  Files           501      502       +1     
  Lines         12398    12405       +7     
  Branches       1567     1568       +1     
============================================
+ Hits           4263     4265       +2     
- Misses         7557     7562       +5     
  Partials        578      578              
Impacted Files Coverage Δ Complexity Δ
.../nodemanager/service/implement/NodeFileLoader.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...i/alcor/nodemanager/utils/NodeManagerConstant.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ewei/alcor/portmanager/proxy/NodeManagerProxy.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...turewei/alcor/nodemanager/service/NodeService.java 50.00% <50.00%> (ø) 1.00 <1.00> (?)
...com/futurewei/alcor/macmanager/utils/MacUtils.java 56.52% <0.00%> (-8.70%) 7.00% <0.00%> (-1.00%)
...alcor/elasticipmanager/dao/ElasticIpAllocator.java 63.81% <0.00%> (+0.27%) 48.00% <0.00%> (ø%)
...alcor/portmanager/util/RestParameterValidator.java 46.15% <0.00%> (+3.07%) 14.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c7baf54...19a0352. Read the comment docs.