search

futurewei-cloud / alcor

Alcor: Cloud native SDN platform powered by Kubernetes and Istio
MIT License
32 stars 33 forks source link

[RM & PM] Add/delete gateway port workflow update #621

Closed kevin-zhonghao closed 3 years ago

kevin-zhonghao commented 3 years ago

Update add/delete gateway port workflow:

  1. Add InternalRouterInfo property in RouterUpdateInfo。

  2. Modified the logic code for constructing RouterUpdateInfo in add/remove interface to Neutron router API.

  3. Update logic of using RouterUpdateInfo to construct networkConfiguration in PortServiceImpl

codecov-commenter commented 3 years ago

Codecov Report

Merging #621 (0a1183c) into master (df94638) will increase coverage by 0.00%. The diff coverage is 22.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #621   +/-   ##
=========================================
  Coverage     31.90%   31.90%           
- Complexity     1247     1249    +2     
=========================================
  Files           525      525           
  Lines         13462    13490   +28     
  Branches       1666     1669    +3     
=========================================
+ Hits           4295     4304    +9     
- Misses         8580     8598   +18     
- Partials        587      588    +1
Impacted Files Coverage Δ
...lcor/route/service/Impl/RouterToPMServiceImpl.java 5.71% <0.00%> (+0.58%) :arrow_up:
...r/route/service/Impl/NeutronRouterServiceImpl.java 37.67% <8.00%> (-1.54%) :arrow_down:
...lcor/route/controller/NeutronRouterController.java 59.52% <50.00%> (-0.24%) :arrow_down:
...wei/alcor/portmanager/service/PortServiceImpl.java 64.53% <100.00%> (+0.62%) :arrow_up:
...alcor/portmanager/util/RestParameterValidator.java 46.15% <0.00%> (+3.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df94638...0a1183c. Read the comment docs.