[RM] getSubnetRouteTable in RouterServiceImpl.java should separate Neutron and VPC router scenario.

futurewei-cloud / alcor

Alcor: Cloud native SDN platform powered by Kubernetes and Istio

MIT License

32 stars 33 forks source link

[RM] getSubnetRouteTable in RouterServiceImpl.java should separate Neutron and VPC router scenario. #647

Open cj-chung opened 3 years ago

cj-chung commented 3 years ago

Issue: getSubnetRouteTable in RouterServiceImpl.java is used by both Neutron and VPC scenarios, but it's only deal with VPC scenario in the code.

Suggestion: Add a flag as an input argument in getSubnetRouteTable to indicate the caller's scenario (Neutron or VPC).

xieus commented 3 years ago

@DavidLiu506 Could you also take on this fix as well as Issue #646? Thanks.

xieus commented 3 years ago

@kevin-zhonghao Can you also take a look at this issue? Thanks!

kevin-zhonghao commented 3 years ago

@kevin-zhonghao Can you also take a look at this issue? Thanks!

Sure, fix in PR#657