Change the atomicity mode of some caches to transactional to fix issue 682

futurewei-cloud / alcor

Alcor: Cloud native SDN platform powered by Kubernetes and Istio

MIT License

32 stars 33 forks source link

Change the atomicity mode of some caches to transactional to fix issue 682 #683

Closed pkommoju closed 2 years ago

pkommoju commented 3 years ago

Change all caches in Port Manager to transactional atomicity. Mixing caches of different atomicity mode under a transaction does not work in Ignite. This was causing a failure in concurrent deletion of ports.

Linked to Issue #682

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert and fixes 1 when merging 5dcec47643a537e00a3653442329f9ae09e43b65 into b4a4288a9a452cd17652a91119021afcd9bcbd7c - view on LGTM.com

new alerts:

1 for Dereferenced variable may be null

fixed alerts:

1 for Boxed variable is never null

xieus commented 2 years ago

How about this PR? @pkommoju We are seeing quite a few of conflicting files.

pkommoju commented 2 years ago

Yes, this is expected because changes in two branches are getting combined into one. Let me take a look at them and attach a patch/comments about what to keep what to remove.

pkommoju commented 2 years ago

Abandon this PR and branch. I didn't realize it quickly enough.

PR#685 already brought in all these changes.

xieus commented 2 years ago

Close this PR as it is duplicated with PR #685.