Enable pulsar client support VPC-topic mode based on GSv1 and GSv2

[VanderChen]

Due to the requirement of GoalState V2, this PR should be reviewed and merged after PR #625.

[lgtm-com[bot]]

This pull request introduces 9 alerts when merging a8e58a72d4ea2538e8beef453a478cc4cdef2767 into 91af57ea8156dd98fb2b3b9769388c9f53cbfe7a - view on LGTM.com

new alerts:

• 7 for Useless null check
• 1 for Container contents are never accessed
• 1 for Boxed variable is never null

[cj-chung]

@VanderChen The current PR seems has overlaps with PR #625. Please consolidate these two PRs as one PR.

[cj-chung]

@VanderChen PR #625 is already merged to master, please update your current PR by pull upstream master to your branch.

[lgtm-com[bot]]

This pull request introduces 1 alert when merging c0345cbedd2e65ca16a230120ca08d6cffb88bfc into 29224cb1ca6609143d752547f962a653697efd66 - view on LGTM.com

new alerts:

• 1 for Boxed variable is never null

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 3ca5deb5c4cd5e40172590673e5566ede0aded14 into a8436227f3d3d459efbfbff0b9a5195c7ea07e5d - view on LGTM.com

new alerts:

• 1 for Boxed variable is never null

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 914016f22f1d3f7c91a809c534e77083e88b16e0 into 97fc7b8482320f121889dd4211f71b29a77d6275 - view on LGTM.com

new alerts:

• 1 for Boxed variable is never null

[xieus]

@VanderChen Ping me on Slack or here in this ticket when this is ready to review.

[lgtm-com[bot]]

This pull request introduces 1 alert when merging f4dd890a0e1a3682c1fe04fd3aee7c81459f1b02 into b464aa9e822d00fe523f3f43fa4fd9d49b1695bd - view on LGTM.com

new alerts:

• 1 for Boxed variable is never null

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 199f6f4865e30e11fccc3c459f606d6c157dd84c into 39a72d132d0000e25a532b0f89d5c7aed3cca714 - view on LGTM.com

new alerts:

• 1 for Boxed variable is never null

[lgtm-com[bot]]

This pull request introduces 1 alert when merging e466a4606cb031ad43f8cdf11e6fe590a16aebfe into 39a72d132d0000e25a532b0f89d5c7aed3cca714 - view on LGTM.com

new alerts:

• 1 for Boxed variable is never null

[xieus]

@VanderChen Could you start a Jenkins workflow to make sure no regression is observed, and plus get @cj-chung's sign off?

[VanderChen]

@VanderChen Could you start a Jenkins workflow to make sure no regression is observed, and plus get @cj-chung's sign off?

@xieus I'll try in Jenkins as soon as possible. However, Jenkins seems only to support gRPC now.

[cj-chung]

@VanderChen The USE_GRPC in your PathManagerService is set to true:

private static boolean USE_GRPC = true;

That's mean your code should use grpc channel and pass in the Jenkins test, but it's failed in the add_router_interface.

Attaching subnets to router
PUTing http request
http://localhost:9009/project/3dda2801-d675-4688-a63f-dcda8d327f50/routers/11112801-d675-4688-a63f-dcda8d327f50/add_router_interface {'subnet_id': '8182a4d4-ffff-4ece-b3f0-8d36e3d88001'}
PUT Failed for http://localhost:9009/project/3dda2801-d675-4688-a63f-dcda8d327f50/routers/11112801-d675-4688-a63f-dcda8d327f50/add_router_interface with error
<bound method Response.json of <Response [500]>>
ERROR 500 Server Error: Internal Server Error for url: http://localhost:9009/project/3dda2801-d675-4688-a63f-dcda8d327f50/routers/11112801-d675-4688-a63f-dcda8d327f50/add_router_interface
500 Server Error: Internal Server Error for url: http://localhost:9009/project/3dda2801-d675-4688-a63f-dcda8d327f50/routers/11112801-d675-4688-a63f-dcda8d327f50/add_router_interface
Build step 'Execute shell' marked build as failure

@pkommoju Please add more debug info here from Jenkins. Thanks.

*** No more debug info is possible in this context, the call is into a python module (requests.post), and on error all of the response is printed. Increasing the application logging level might help.

[VanderChen]

@VanderChen The USE_GRPC in your PathManagerService is set to true:

private static boolean USE_GRPC = true;

That's mean your code should use grpc channel and pass in the Jenkins test, but it's failed in the add_router_interface.

Attaching subnets to router
PUTing http request
http://localhost:9009/project/3dda2801-d675-4688-a63f-dcda8d327f50/routers/11112801-d675-4688-a63f-dcda8d327f50/add_router_interface {'subnet_id': '8182a4d4-ffff-4ece-b3f0-8d36e3d88001'}
PUT Failed for http://localhost:9009/project/3dda2801-d675-4688-a63f-dcda8d327f50/routers/11112801-d675-4688-a63f-dcda8d327f50/add_router_interface with error
<bound method Response.json of <Response [500]>>
ERROR 500 Server Error: Internal Server Error for url: http://localhost:9009/project/3dda2801-d675-4688-a63f-dcda8d327f50/routers/11112801-d675-4688-a63f-dcda8d327f50/add_router_interface
500 Server Error: Internal Server Error for url: http://localhost:9009/project/3dda2801-d675-4688-a63f-dcda8d327f50/routers/11112801-d675-4688-a63f-dcda8d327f50/add_router_interface
Build step 'Execute shell' marked build as failure

@pkommoju Please add more debug info here from Jenkins. Thanks.

*** No more debug info is possible in this context, the call is into a python module (requests.post), and on error all of the response is printed. Increasing the application logging level might help.

@cj-chung Hi, James. I have noted this when the test is run in Jenkins. I'm working on it locally to solve this 500 error. This fix will be submitted as soon as possible.

[cj-chung]

@VanderChen Which part of code you have modified to make the Jenkins test cases passed?