search

futurewei-cloud / alioth-app

MIT License
1 stars 2 forks source link

add prototype of packet_delay #9

Closed lin-yifan1 closed 1 year ago

lin-yifan1 commented 1 year ago

a prototype of packet delay, varified with tofino model.

r12f commented 1 year ago

great to see this change! I have reviewed and added a few comments.

and btw, do you mind to also move the source code to zion/poc/packet_delay? so in the future, it won't confuse people with our final code.

lin-yifan1 commented 1 year ago

Oops, I didn't noticed the repo structure part in README. It's OK now.

r12f commented 1 year ago

Also just in case, I have left some review comments in this PR. and since we changed the folder structure, it might not show up in the "FIles Changed" tab.

lin-yifan1 commented 1 year ago

I just noticed that I forgot to update the code comments in packet_delay.tna.p4 after debug, so it might seem confusing.