futurice / freesound-android

Unofficial Android client for the Freesound Project
Apache License 2.0
85 stars 16 forks source link

RxJava 2 CompositeDisposable usage #130

Closed ghost closed 7 years ago

ghost commented 7 years ago

Hi, from what i read recently sounds that if we want to use CompositeDisposable then we need to use subscribeWith and DisposableObserver (and other consumers for each (single, maybe, completable ...)).

An example here: https://github.com/amitshekhariitbhu/RxJava2-Android-Samples/blob/master/app/src/main/java/com/rxjava2/android/samples/ui/operators/DisposableExampleActivity.java

You tested if your current implementation works?

peter-tackage commented 7 years ago

I believe that's only relevant if you are subscribing with a single Observer public final void subscribe(Observer<? super T> observer, rather than the overloaded versions with individual Consumer instances which we use.

Did you find a bug with the current implementation?