futurice / freesound-android

Unofficial Android client for the Freesound Project
Apache License 2.0
85 stars 16 forks source link

Suggestion on how we can do arrange builder #139

Closed tomaszpolanski closed 7 years ago

peter-tackage commented 7 years ago

Looks similar to what I was thinking: https://gist.github.com/peter-tackage/7ce277b6c77a1a68411207c909d672b4

tomaszpolanski commented 7 years ago

I would avoid too complex inner class structures, we can try it out case by case basis. For the class that I am testing, I would say that's enough. For more complex scenarios we can have something more sophisticated.

peter-tackage commented 7 years ago

Yeah, I played with Act and Assert as a part of the DSL but there's too many combinations of structures to find a common nesting pattern. We're better off, like you said, by just starting with Arrange and seeing what comes of it.