futurice / freesound-android

Unofficial Android client for the Freesound Project
Apache License 2.0
85 stars 16 forks source link

Remove parcel test #171

Closed peter-tackage closed 6 years ago

peter-tackage commented 6 years ago

This test is currently ineffective as it is comparing the same instance, rather than than two separate instances created via the marshalling/unmarshalling logic.

For now, I want to remove the test because it creates a false sense of security. Hopefully if this issue is resolved, it will be possible to access the CREATOR instance: https://youtrack.jetbrains.com/issue/KT-19300

Refer to this for a good general pattern for Parcel testing: http://www.kevinrschultz.com/blog/2014/03/01/how-not-to-test-androids-parcelable-interface/