Closed luciapayo closed 8 years ago
@peter-tackage is this ok to be merged?
@luciapayo I'm back on reviewing now, I'm still not convinced about the int vs enum proposition. I'm trying a few things in the branch to see what works best.
@peter-tackage I am getting this compile error: Error:(27, 38) error: package com.ryanharter.auto.value.gson does not exist
Any ideas? (I already cleaned, invalidated cached and restarted :P)
I see the same problem on your branch. I remember seeing something similar before - I'll investigate.
@luciapayo Oddly, I think the problem is that your DisplayableItem
definition is not consistent with its Builder
.
Parameter type of setter method should be int to match getter com.futurice.freesound.viewmodel.DisplayableItem.type Builder
type(@NonNull Type type);
To fix it, change:
public abstract int type();
to
public abstract Type type();
@peter-tackage It is already public abstract Type type();
and not public abstract int type();
but still does not compile for me :(
@luciapayo Looking at your PR, the signature of DisplayableItem
still has public abstract int type();
@peter-tackage have you pulled? EDIT: Forget about it, I fixed the Builder but not the attribute declaration :facepalm: Sorry!
This is the first step for #15. It also the first step to make a RecyclerAdapter that is generic and not item based so it can be reused.