futurice / freesound-android

Unofficial Android client for the Freesound Project
Apache License 2.0
85 stars 16 forks source link

Extract library versions into ext properties #64

Closed peter-tackage closed 7 years ago

peter-tackage commented 7 years ago

Implementation of #33. Currently I've only done it for the library dependency versions. Should I do the rest too? I've also extracted the versions when they aren't used multiple times, it just seemed neater, although it does add some cognitive load for looking up the version & extra work when adding new libraries (you need to add the version into ext properties list, rather than just copy the suggested gradle dependency).

peter-tackage commented 7 years ago

I now wondering if the dictionary approach might be better. Like this - https://github.com/AdamLuisSean/AndroidCleanVIPER/blob/master/dependencies/dependencies.gradle

tomaszpolanski commented 7 years ago

I don't think it matters, both approached are almost identical