search

futurice / freesound-android

Unofficial Android client for the Freesound Project
Apache License 2.0
85 stars 16 forks source link

Search error reporting #65

Closed ghost closed 7 years ago

ghost commented 7 years ago

Could you have a quick look if this is a good start? It shows an error if the search goes wrong, there are still more things to understand about the flow of rx in this project to make it behave correctly though.

peter-tackage commented 7 years ago

@maritoast You'll also need to add unit tests (at least) for the new functionality.

peter-tackage commented 7 years ago

@maritoast I've tested the master branch and you are correct to say that a search failure (onError) causes future searches not to occur was a problem before your changes.

tomaszpolanski commented 7 years ago

@peter-tackage It seems that travis is freaking out, any ideas?

peter-tackage commented 7 years ago

@tomaszpolanski @maritoast I've rerun the tests on the Travis side and they now pass. I'm not 100% sure of what the problem is, but it's not specifically related to our tests.