search

futurice / ios-good-practices

Good ideas for iOS development, by Futurice developers.
http://www.futurice.com
Other
10.83k stars 1.24k forks source link

Add note that CocoaPods recommend checking pods into source code. #79

Closed erwald closed 5 years ago

erwald commented 5 years ago

@siddharthsuneel and @mkko, does the latest version look agreeable to you?

mkko commented 5 years ago

I personally wouldn't mind the clutter (stating the notable reasons of doing so), as I would like to treat this more as a full-fledged, opinionated guide and less of an aggregated list.

What do you think if we added the two pros @boris-tschirschwitz mentioned? I would also add that the builds are guaranteed to be reproducible from the same commit.

siddharthsuneel commented 5 years ago

@erwald yes, this new version looks good & more appropriate to me...

erwald commented 5 years ago

@mkko I definitely want this to be a more opinionated document as well (that's the consensus among us in general in Berlin).

As for adding the two pros, Boris and I discussed it and don't really see the benefit when it's available in the links in any case. I think most readers are just looking for the recommended best practice and don't care so much about the why. And if they do, the sources are there.

mkko commented 5 years ago

I understand, it might feel redundant and as repetition. I just feel this guide should host our reasoning, be it from our experience or someone else's. Also in general the content behind these links might change, which makes our opinions kind of unstable.

I'm fine with your reasoning though, if you prefer to keep this guide more concise.